-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Split methods pass into a new crate take 2 #15280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jarcho
wants to merge
10
commits into
rust-lang:master
Choose a base branch
from
Jarcho:split_methods_pass
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep results together. * Keep lints in a map to detect duplicate names. * Store the crate a lint comes from.
Seems that you are trying to add a new lint! We are currently in a feature freeze, so we are delaying all lint-adding PRs to September 18 and focusing on bugfixes. Thanks a lot for your contribution, and sorry for the inconvenience. With ❤ from the Clippy team. @rustbot note Feature-freeze |
a47996a
to
461e0e3
Compare
275fc1b
to
2730f94
Compare
2730f94
to
87b553a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #15279, #15277 and #15270.
This still needs
dev new_lints
changes and some cleanup work needs to be done. First commit of the split just moves the files to their new location. Hopefully that's enough to allow git to deal with merging nicely.cc @flip1995
changelog: none
Summary Notes
Managed by
@rustbot
—see help for details